Skip to content

test: tolerate Windows timing jitter - #736

Merged
rafaelscosta merged 1 commit into
mainfrom
fix/windows-node18-timing-budget
May 14, 2026
Merged

test: tolerate Windows timing jitter#736
rafaelscosta merged 1 commit into
mainfrom
fix/windows-node18-timing-budget

Conversation

@rafaelscosta

@rafaelscosta rafaelscosta commented May 14, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • relax Windows-only jitter tolerance in the UAP session bridge timing comparison
  • keeps the non-Windows tolerance unchanged

Validation

  • npm test -- tests/synapse/bridge/uap-session-bridge.test.js --runInBand
  • npm run lint -- --no-cache tests/synapse/bridge/uap-session-bridge.test.js
  • git diff --check

Context

Follow-up to the Windows Node 18 CI failure after PR #735. The failed assertion was a millisecond-level timing flake: expected less than or equal to 2ms, received 3ms. It is not related to the Pro installer hotfix.

Summary by CodeRabbit

  • Tests
    • Updated platform-specific timing tolerances in session bridge tests to improve test reliability across different operating systems.

Review Change Stack

@vercel

vercel Bot commented May 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aiox-core Ready Ready Preview, Comment May 14, 2026 3:21pm

Request Review

@github-actions github-actions Bot added type: test Test coverage and quality area: docs Documentation (docs/) labels May 14, 2026
@coderabbitai

coderabbitai Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: faf52805-ff8d-401f-8be9-6bc8748b4c83

📥 Commits

Reviewing files that changed from the base of the PR and between b48c475 and 6af4af8.

📒 Files selected for processing (1)
  • tests/synapse/bridge/uap-session-bridge.test.js

Walkthrough

This PR adjusts timing-budget tolerance in a performance test to improve reliability across platforms. The assertion now applies platform-dependent jitter allowance—5ms on Windows, 1ms elsewhere—instead of a uniform 1ms tolerance, reducing intermittent test failures on slower or variable-latency platforms.

Changes

Test Timing-Budget Assertion

Layer / File(s) Summary
Platform-dependent timing tolerance
tests/synapse/bridge/uap-session-bridge.test.js		 The skip-vs-write path timing assertion tolerance becomes platform-aware, accepting larger jitter on Windows to accommodate higher performance variance and reduce flakiness.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

type: test, area: synapse

Suggested reviewers

  • Pedrovaleriolopez
  • oalanicolas
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: relaxing timing tolerances specifically for Windows in a test file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-node18-timing-budget

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

Coverage report not available

📈 Full coverage report available in Codecov

Generated by PR Automation (Story 6.1)

@rafaelscosta
rafaelscosta merged commit c577250 into main May 14, 2026
41 checks passed
@rafaelscosta
rafaelscosta deleted the fix/windows-node18-timing-budget branch May 14, 2026 15:24
tuanmedeiros pushed a commit to tuanmedeiros/aios-core-synkraay that referenced this pull request Jun 2, 2026
@rafaelscosta
test: tolerate Windows timing jitter (SynkraAI#736)
bedef01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@Pedrovaleriolopez Pedrovaleriolopez Awaiting requested review from Pedrovaleriolopez Pedrovaleriolopez is a code owner
@oalanicolas oalanicolas Awaiting requested review from oalanicolas oalanicolas is a code owner

Assignees

No one assigned

Labels

area: docs Documentation (docs/) type: test Test coverage and quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rafaelscosta